Update Petclinic and Spring Boot Helm chart references #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we still need to update the petclinic and helm chart ref after they get merged. |
nihussmann
commented
Jan 28, 2025
| @@ -386,12 +386,12 @@ class Config { | |||
| RepositorySchemaWithRef springBootHelmChart = new RepositorySchemaWithRef( | |||
| // Take from env or use default because the Dockerfile provides a local copy of the repo | |||
| url: System.getenv('SPRING_BOOT_HELM_CHART_REPO') ?: 'https://github.com/cloudogu/spring-boot-helm-chart.git', | |||
| ref: '0.3.2' | |||
| ref: 'b6d3bbd' | |||
There was a problem hiding this comment.
Suggested change
| ref: 'b6d3bbd' | |
| ref: '0.4.0' |
nihussmann
force-pushed
the
feature/update-springhelm-petclinic
branch
2 times, most recently
from
dfe69a7 to
92aeb52
Compare
nihussmann
force-pushed
the
feature/update-springhelm-petclinic
branch
from
92aeb52 to
bb30fa6
Compare
| ) | ||
| @JsonPropertyDescription(SPRING_PETCLINIC_DESCRIPTION) | ||
| RepositorySchemaWithRef springPetclinic = new RepositorySchemaWithRef( | ||
| url: System.getenv('SPRING_PETCLINIC_REPO') ?: 'https://github.com/cloudogu/spring-petclinic.git', | ||
| ref: 'b0e0d18' | ||
| ref: 'faf9b7c' |
There was a problem hiding this comment.
possible to use tag?
schnatterer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.