-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/53 add pod security #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add docs for all capabilities Co-authored-by: Philipp Pixel <ppxl@users.noreply.github.com>
Co-authored-by: Alexander Dammeier <alexander.dammeier@cloudogu.com>
b7c134a
to
959c5ff
Compare
Co-authored-by: Alexander Dammeier <alexander.dammeier@cloudogu.com>
There is no way to formalize list entries in JSON, so the capabilities slice could contain anything. This commit adds a way to check these and fail if the list contains unknown capabilities
In a previous commit the go version was raised to 1.23. This commit amends this situation for the Makefile
Co-authored-by: Philipp Pixel <ppxl@users.noreply.github.com>
The validate function was not located in the best possible location, that was: during parsing dogus from strings. That might interfere with parsing otherwise empty dogus which would then be possibly considered invalid. Instead, this commit extracts this very method onto the dogu struct so developers can call this function independent of the parsing method. This commit removes the respective bulk dogu counterpart because YAGNI
…ator Co-authored-by: Alexander Dammeier <alexander.dammeier@cloudogu.com>
jelemux
reviewed
Dec 12, 2024
jelemux
reviewed
Dec 12, 2024
This allows us to use them in the dogu operator and prevents us from keeping two lists in sync.
+ better error handling
ppxl
commented
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #53 by adding and describing container security features