Ensure players are in correct scoreboard team when they join#14
Merged
Ensure players are in correct scoreboard team when they join#14
Conversation
Member
zefir-git
commented
May 14, 2024
zefir-git
commented
- If the player is not a member but in a nation's team, they are removed from it.
- If the member is not in a nation, but in a nation's team, they are removed from it.
- If the member is in a nation, ensures they are in that nation's team.
```
java.lang.IllegalArgumentException: Entry cannot be null
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:143) ~[guava-32.1.2-jre.jar:?]
at org.bukkit.craftbukkit.v1_20_R3.scoreboard.CraftTeam.addEntry(CraftTeam.java:226) ~[paper-1.20.4.jar:git-Paper-496]
at org.bukkit.craftbukkit.v1_20_R3.scoreboard.CraftTeam.addPlayer(CraftTeam.java:221) ~[paper-1.20.4.jar:git-Paper-496]
```
kai-gitt
approved these changes
May 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.