Skip to content

fix(webhook): use correct API group in webhook errors#8485

Merged
mnencia merged 2 commits intomainfrom
dev/wrong-invalid-api
Sep 3, 2025
Merged

fix(webhook): use correct API group in webhook errors#8485
mnencia merged 2 commits intomainfrom
dev/wrong-invalid-api

Conversation

@armru
Copy link
Member

@armru armru commented Aug 29, 2025

Replace incorrect GroupKind group with "postgresql.cnpg.io" in Pooler ValidateUpdate admission error to align with the CRD group and ensure consistent API error reporting.

Also fixed inside backup webhook.

@armru armru added the no-issue label Aug 29, 2025
@armru armru requested a review from a team as a code owner August 29, 2025 13:30
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 29, 2025
@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.25 release-1.26 release-1.27 labels Aug 29, 2025
@github-actions
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@dosubot dosubot bot added lgtm This PR has been approved by a maintainer bug 🐛 Something isn't working ok to merge 👌 This PR can be merged labels Aug 29, 2025
@armru armru changed the title fix(webhook): use correct API group in Pooler webhook errors fix(webhook): use correct API group in webhook errors Aug 29, 2025
Replace incorrect GroupKind group with "postgresql.cnpg.io" in
Pooler ValidateUpdate admission error to align with the CRD group
and ensure consistent API error reporting.

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@mnencia mnencia force-pushed the dev/wrong-invalid-api branch from e921a9d to 0accfe7 Compare September 3, 2025 14:40
@mnencia mnencia merged commit 6eed116 into main Sep 3, 2025
34 checks passed
@mnencia mnencia deleted the dev/wrong-invalid-api branch September 3, 2025 15:45
cnpg-bot pushed a commit that referenced this pull request Sep 3, 2025
Fix the incorrect API group reported by the Pooler and Backup
admission webhook.

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit 6eed116)
cnpg-bot pushed a commit that referenced this pull request Sep 3, 2025
Fix the incorrect API group reported by the Pooler and Backup
admission webhook.

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit 6eed116)
cnpg-bot pushed a commit that referenced this pull request Sep 3, 2025
Fix the incorrect API group reported by the Pooler and Backup
admission webhook.

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit 6eed116)
THE-BRAHMA pushed a commit to THE-BRAHMA/cloudnative-pg that referenced this pull request Oct 6, 2025
…#8485)

Fix the incorrect API group reported by the Pooler and Backup
admission webhook.

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: theBrahma <office.utpal.brahma@gmail.com>
THE-BRAHMA pushed a commit to THE-BRAHMA/cloudnative-pg that referenced this pull request Oct 30, 2025
…#8485)

Fix the incorrect API group reported by the Pooler and Backup
admission webhook.

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: theBrahma <office.utpal.brahma@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-requested ◀️ This pull request should be backported to all supported releases bug 🐛 Something isn't working lgtm This PR has been approved by a maintainer no-issue ok to merge 👌 This PR can be merged release-1.25 release-1.26 release-1.27 size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants