Conversation
armru
requested review from
a team,
NiccoloFei,
jsilvela and
litaocdl
as code owners
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
armru
changed the title
prepare commandprepare command
mnencia
reviewed
Mar 3, 2025
Member
mnencia
left a comment
mnencia
left a comment
There was a problem hiding this comment.
This is half of the required work. The "prepare" command is still called in .github/workflows/continuous-delivery.yml and needs to be replaced with the appropriate github action to install kind and kubectl.
Collaborator
NiccoloFei
approved these changes
Mar 4, 2025
mnencia
reviewed
Mar 4, 2025
Closes #7050 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
mnencia
approved these changes
Mar 5, 2025
Member
|
/ok-to-merge |
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
The `hack/setup-cluster.sh` prepare subcommand was once essential for E2E environment setup. Now, this is fully handled by the GitHub workflow, which automatically installs the right versions of kind and kubectl. Closes #7050 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> (cherry picked from commit 7e6af25)
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
The `hack/setup-cluster.sh` prepare subcommand was once essential for E2E environment setup. Now, this is fully handled by the GitHub workflow, which automatically installs the right versions of kind and kubectl. Closes #7050 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> (cherry picked from commit 7e6af25)
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
The `hack/setup-cluster.sh` prepare subcommand was once essential for E2E environment setup. Now, this is fully handled by the GitHub workflow, which automatically installs the right versions of kind and kubectl. Closes #7050 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> (cherry picked from commit 7e6af25)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7050