Skip to content

test: fix race in metrics tests#6969

Merged
mnencia merged 1 commit intomainfrom
dev/6968
Feb 25, 2025
Merged

test: fix race in metrics tests#6969
mnencia merged 1 commit intomainfrom
dev/6968

Conversation

@fcanovai
Copy link
Contributor

@fcanovai fcanovai commented Feb 25, 2025 •
edited
Loading

Wait for the GRANT to be replicated on the replica server before querying the metrics endpoint.

Closes #6968

@fcanovai
Copy link
Contributor Author

fcanovai commented Feb 25, 2025

Test run in fork: https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/13523731063

@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.24 release-1.25 labels Feb 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@fcanovai @mnencia
test: fix race in metrics tests
62d8b37 
Wait for the GRANT to be replicated on the replica server before
querying the metrics endpoint.

Closes #6968

Signed-off-by: Francesco Canovai <francesco.canovai@enterprisedb.com>
@mnencia
Copy link
Member

mnencia commented Feb 25, 2025

/ok-to-merge E2E green on the EDB fork

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Feb 25, 2025
@mnencia mnencia merged commit c98e0c3 into main Feb 25, 2025
24 of 25 checks passed
@mnencia mnencia deleted the dev/6968 branch February 25, 2025 17:29
cnpg-bot pushed a commit that referenced this pull request Feb 25, 2025
@fcanovai
test: fix race in metrics tests (#6969)
270e433 
Wait for the GRANT to be replicated on the replica server before
querying the metrics endpoint.

Closes #6968

Signed-off-by: Francesco Canovai <francesco.canovai@enterprisedb.com>
(cherry picked from commit c98e0c3)
cnpg-bot pushed a commit that referenced this pull request Feb 25, 2025
@fcanovai
test: fix race in metrics tests (#6969)
4a51b83 
Wait for the GRANT to be replicated on the replica server before
querying the metrics endpoint.

Closes #6968

Signed-off-by: Francesco Canovai <francesco.canovai@enterprisedb.com>
(cherry picked from commit c98e0c3)
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Closed
mnencia pushed a commit that referenced this pull request Feb 25, 2025
@fcanovai @mnencia
test: fix race in metrics tests (#6969)
e9014d1 
Wait for the GRANT to be replicated on the replica server before
querying the metrics endpoint.

Closes #6968

Signed-off-by: Francesco Canovai <francesco.canovai@enterprisedb.com>
(cherry picked from commit c98e0c3)
@ardentperf ardentperf mentioned this pull request Sep 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnencia mnencia mnencia approved these changes

@leonardoce leonardoce leonardoce approved these changes

@jsilvela jsilvela Awaiting requested review from jsilvela jsilvela is a code owner

@NiccoloFei NiccoloFei Awaiting requested review from NiccoloFei NiccoloFei is a code owner

@litaocdl litaocdl Awaiting requested review from litaocdl litaocdl is a code owner

+1 more reviewer

@gabriele-wolfox gabriele-wolfox gabriele-wolfox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.22 release-1.24 release-1.25

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: missing SELECT permission in metrics e2e test

5 participants

@fcanovai @mnencia @leonardoce @gabriele-wolfox @cnpg-bot