Skip to content

feat: clean up logging of database, publication, subscriptio controllers#6268

Merged
mnencia merged 3 commits intocloudnative-pg:mainfrom
EnterpriseDB:dev/5524
Dec 4, 2024
Merged

feat: clean up logging of database, publication, subscriptio controllers#6268
mnencia merged 3 commits intocloudnative-pg:mainfrom
EnterpriseDB:dev/5524

Conversation

@jsilvela
Copy link
Collaborator

@jsilvela jsilvela commented Dec 4, 2024

Ensures that the primary pod has a clear indication of when a
database/publication/subscription is being reconciled, whether it succeeds,
or there is any error.
Puts those logs at the Info level so they're there by default.
Neither replica instances nor the controller will get any logs.

Closes #5524

@jsilvela jsilvela requested a review from a team as a code owner December 4, 2024 11:18
@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 release-1.24 labels Dec 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@armru
Copy link
Member

armru commented Dec 4, 2024

/test limit=local

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/12162540073

@mnencia
Copy link
Member

mnencia commented Dec 4, 2024

/ok-to-merge green tests. only unrelated known failures

jsilvela and others added 3 commits December 4, 2024 22:44
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: wolfox <gabriele.quaresima@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Dec 4, 2024
@mnencia mnencia merged commit f95015a into cloudnative-pg:main Dec 4, 2024
@mnencia mnencia deleted the dev/5524 branch December 4, 2024 21:50
@mnencia mnencia added do not backport This PR must not be backported - it will be in the next minor release and removed backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 release-1.24 labels Dec 5, 2024
jsilvela added a commit to EnterpriseDB/cloudnative-pg that referenced this pull request Dec 5, 2024
…ers (cloudnative-pg#6268)

This update enhances the logging mechanisms for the database, publication,
and subscription controllers. It ensures more consistent and informative
log messages, making debugging and monitoring easier. 

Closes cloudnative-pg#5524

Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: wolfox <gabriele.quaresima@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: wolfox <gabriele.quaresima@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not backport This PR must not be backported - it will be in the next minor release ok to merge 👌 This PR can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Harmonize database reconciler logging

5 participants