Skip to content

chore(perf): Use controller-runtime pprof server#6000

Merged
sxd merged 2 commits intomainfrom
dev/improve_pprof
Nov 18, 2024
Merged

chore(perf): Use controller-runtime pprof server#6000
sxd merged 2 commits intomainfrom
dev/improve_pprof

Conversation

@sxd
Copy link
Member

@sxd sxd commented Oct 31, 2024

The controller-runtime provides a pprof server that we can just enable,
this use that capability and remove the pprof server we used to have.

Closes #5999

@sxd sxd requested a review from a team as a code owner October 31, 2024 16:44
@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 release-1.24 labels Oct 31, 2024
@github-actions
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@armru armru force-pushed the dev/improve_pprof branch from 5efae9a to 814816c Compare November 11, 2024 16:03
@sxd
Copy link
Member Author

sxd commented Nov 14, 2024

/test depth=push feature_type=basic

@github-actions
Copy link
Contributor

@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/11835216989

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Nov 14, 2024
sxd and others added 2 commits November 18, 2024 15:07
The controller-runtime provides a pprof server that we can just enable,
this use that capability and remove the pprof server we used to have.

Closes #5999

Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@sxd sxd force-pushed the dev/improve_pprof branch from fdae7de to d6b960b Compare November 18, 2024 14:08
@sxd sxd merged commit c556f59 into main Nov 18, 2024
@sxd sxd deleted the dev/improve_pprof branch November 18, 2024 14:44
cnpg-bot pushed a commit that referenced this pull request Nov 18, 2024
The controller-runtime provides a pprof server that we can just enable,
this use that capability and remove the pprof server we used to have.

Closes #5999

Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit c556f59)
cnpg-bot pushed a commit that referenced this pull request Nov 18, 2024
The controller-runtime provides a pprof server that we can just enable,
this use that capability and remove the pprof server we used to have.

Closes #5999

Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit c556f59)
cnpg-bot pushed a commit that referenced this pull request Nov 18, 2024
The controller-runtime provides a pprof server that we can just enable,
this use that capability and remove the pprof server we used to have.

Closes #5999

Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit c556f59)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.22 release-1.23 release-1.24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Use controller-runtime pprof server

4 participants