fix(webhook): validate the number of synchronous replicas#5985
Merged
gbartolini merged 4 commits intomainfrom Oct 31, 2024
Merged
fix(webhook): validate the number of synchronous replicas#5985gbartolini merged 4 commits intomainfrom
synchronous replicas#5985gbartolini merged 4 commits intomainfrom
Conversation
Member
Author
|
/test limit=local |
4 tasks
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/11594332494 |
armru
changed the title
.synchronous stanza while there is only one instance
armru
changed the title
.synchronous stanza while there is only one instancesynchronous stanza while there is only one instance
armru
changed the title
synchronous stanza while there is only one instancesynchronous stanza with one instance
armru
force-pushed
the
dev/5964
branch
2 times, most recently
from
fb606f3 to
19be738
Compare
Member
Author
|
/test limit=local |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/11596148713 |
armru
force-pushed
the
dev/5964
branch
2 times, most recently
from
9c21ee2 to
20fe47a
Compare
Member
Author
|
/test limit=local |
armru
changed the title
synchronous stanza with one instance synchronous stanza while having one or less instances
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/11596426784 |
Contributor
|
@armru can we make this more generic? See this comment for example: #5878 (comment) |
Member
Author
|
@gbartolini can you validate if the changes are in line with the expectations? |
gbartolini
changed the title
synchronous stanza while having one or less instances synchronous replicas
gbartolini
approved these changes
Oct 31, 2024
…ance Closes #5964 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
mnencia
approved these changes
Oct 31, 2024
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
cnpg-bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
Closes #5964 ## Release Notes Fix an issue where the user could specify one or fewer instances along with the `synchronous` stanza. When specified together, these parameters would generate an incorrect replica configuration. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 97f1e9e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5964
Release Notes
Fixed a bug where the user could specify one or fewer instances along with the
synchronousstanza. When specified together, these parameters would generate an incorrect replica configuration.Note for the reviewers
While this could have been done with kubebuilder rule, I opted for the code solution given that it is easy to unit-test.