chore: remove code to support PostgreSQL 11 #5794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxd
force-pushed
the
dev/remove_old_code
branch
from
dafa842 to
2e1a7e3
Compare
cnpg-bot
added
backport-requested ◀️
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
sxd
added
no-issue
and removed
backport-requested ◀️
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
3 similar comments
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
sxd
force-pushed
the
dev/remove_old_code
branch
from
2e1a7e3 to
40954ad
Compare
gbartolini
approved these changes
Oct 11, 2024
gbartolini
approved these changes
Oct 11, 2024
Member
Author
|
/test depth=push |
Contributor
|
@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/11295735354 |
gbartolini
added
do not backport
Contributor
|
/test depth=push |
Contributor
|
@gbartolini, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/11297802592 |
gbartolini
force-pushed
the
dev/remove_old_code
branch
from
3b59ffc to
055e8e9
Compare
Contributor
mnencia
force-pushed
the
dev/remove_old_code
branch
2 times, most recently
from
fc5eecd to
0bec79d
Compare
We found some code that it's never executed since we don't support PostgreSQL lower than 12, we remove those piece of code to make some other refactors easier. Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
gbartolini
force-pushed
the
dev/remove_old_code
branch
from
0bec79d to
a98c13b
Compare
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
approved these changes
Oct 15, 2024
cnpg-bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Refactor code to remove any blocks specifically designed to work on a PostgreSQL version < 12. Closes #5797 --------- Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit e227fc7)
cnpg-bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Refactor code to remove any blocks specifically designed to work on a PostgreSQL version < 12. Closes #5797 --------- Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit e227fc7)
mnencia
added a commit
that referenced
this pull request
Oct 15, 2024
Refactor code to remove any blocks specifically designed to work on a PostgreSQL version < 12. Closes #5797 --------- Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code to remove any blocks specifically designed to work on a PostgreSQL version < 12.
Closes #5797