Skip to content

Conversation

@gbartolini
Copy link
Contributor

@gbartolini gbartolini commented Oct 3, 2024

Define standard guidelines in the SUPPORT.md file for professional organisations and individuals who want to be listed as support providers for CloudNativePG.

Closes #5706

@gbartolini gbartolini requested review from a team and jsilvela as code owners October 3, 2024 13:12
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 release-1.24 labels Oct 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

3 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@gbartolini gbartolini changed the title docs: provide guidelines from commercial support docs: provide guidelines for commercial support Oct 3, 2024
@gbartolini gbartolini requested review from armru, mnencia, phisco and sxd October 3, 2024 13:52
@gbartolini gbartolini added the do not merge 🙅 This PR cannot be merged (yet) label Oct 3, 2024
@armru
Copy link
Member

armru commented Oct 4, 2024

I don't think maintainers should be allowed to vet, or even do any validation to the submission to be added to the commercial support page, given that the maintainers are not in position to do any non formal evaluation.

What I suggest is to add a strict template to be added to the commercial support page, for example made by LOGO+LINK like others project do (ex: https://prometheus.io/support-training/). This would translate in a formal check for the link and logo correctness contained in the PR before merging.

@gbartolini
Copy link
Contributor Author

I don't think maintainers should be allowed to vet, or even do any validation to the submission to be added to the commercial support page, given that the maintainers are not in position to do any non formal evaluation.

What I suggest is to add a strict template to be added to the commercial support page, for example made by LOGO+LINK like others project do (ex: https://prometheus.io/support-training/). This would translate in a formal check for the link and logo correctness contained in the PR before merging.

I must admit I tend to agree with you. Even though, in my experience, it is important that we keep the vetting process. A compromise could be to remove the 'description' and limit the submission to:

  • name
  • logo
  • URL

However, IMO, we should ensure at least minimal analysis on the content of the website. This is a standard procedure and I don't think right now it will require a lot of work (I remember I was part of the moderators of the PostgreSQL website for a while and review was an important task).

For example, we should request that the website at least mentions PostgreSQL, Kubernetes and CloudNativePG, providing a link back to our project.

Define standard guidelines in the `SUPPORT.md` file for professional
organisations and individuals who want to be listed as support providers for
CloudNativePG.

Closes #5706

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
@mnencia
Copy link
Member

mnencia commented Oct 7, 2024

/ok-to-merge

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Oct 7, 2024
@gbartolini gbartolini added do not backport This PR must not be backported - it will be in the next minor release backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 release-1.24 and removed do not merge 🙅 This PR cannot be merged (yet) backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 release-1.24 do not backport This PR must not be backported - it will be in the next minor release labels Oct 7, 2024
@gbartolini gbartolini merged commit 1f2841e into main Oct 7, 2024
@gbartolini gbartolini deleted the dev/5706 branch October 7, 2024 09:46
cnpg-bot pushed a commit that referenced this pull request Oct 7, 2024
Define standard guidelines in the `SUPPORT.md` file for professional
organisations and individuals who want to be listed as support providers
for CloudNativePG.

Closes #5706

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
(cherry picked from commit 1f2841e)
cnpg-bot pushed a commit that referenced this pull request Oct 7, 2024
Define standard guidelines in the `SUPPORT.md` file for professional
organisations and individuals who want to be listed as support providers
for CloudNativePG.

Closes #5706

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
(cherry picked from commit 1f2841e)
gbartolini added a commit that referenced this pull request Oct 7, 2024
Define standard guidelines in the `SUPPORT.md` file for professional
organisations and individuals who want to be listed as support providers
for CloudNativePG.

Closes #5706

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
bentastic27 pushed a commit to bentastic27/cloudnative-pg that referenced this pull request Oct 11, 2024
Define standard guidelines in the `SUPPORT.md` file for professional
organisations and individuals who want to be listed as support providers
for CloudNativePG.

Closes cloudnative-pg#5706

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Ben Healey <bentastic27@gmail.com>
bentastic27 pushed a commit to bentastic27/cloudnative-pg that referenced this pull request Oct 11, 2024
Define standard guidelines in the `SUPPORT.md` file for professional
organisations and individuals who want to be listed as support providers
for CloudNativePG.

Closes cloudnative-pg#5706

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Ben Healey <bentastic27@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.22 release-1.23 release-1.24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs]: provide clearer instructions for professional support page

10 participants