feat(managed-services): add support for updateStrategy
#4952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armru
requested review from
jsilvela,
NiccoloFei,
litaocdl and
a team
as code owners
cnpg-bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
armru
added
do not backport
|
/test limit=local |
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9677816242 |
armru
commented
Jun 26, 2024
| @@ -163,4 +164,60 @@ var _ = Describe("Managed services tests", Label(tests.LabelSmoke, tests.LabelBa | |||
| }, testTimeouts[utils.ManagedServices]).Should(Succeed()) | |||
| }) | |||
| }) | |||
|
|
|||
| It("should properly handle replace update strategy", func(ctx SpecContext) { | |||
There was a problem hiding this comment.
Perhaps we could add another E2E that runs in cloud environments and tries to create and update a load balancer.
There was a problem hiding this comment.
It's a good idea, but the test could be very flaky (load balancers are very slow to provision) and may require specific per-CSP tests to be meaningful.
@fcanovai, what do you think?
|
/test limit=local |
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9681716329 |
|
/test limit=local |
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9692909659 |
mnencia
approved these changes
Jun 28, 2024
leonardoce
force-pushed
the
dev/4922
branch
2 times, most recently
from
a97deab to
d550099
Compare
leonardoce
approved these changes
Jul 1, 2024
gbartolini
approved these changes
Jul 1, 2024
Closes #4922 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
samtoxie
pushed a commit
to samtoxie/cloudnative-pg
that referenced
this pull request
Aug 28, 2024
…-pg#4952) Introduce the `updateStrategy` field to control how the operator updates a service definition. By default, the operator uses the `patch` strategy, applying changes directly to the service. Alternatively, the `recreate` strategy deletes the existing service and recreates it from the template. This is particularly useful to handle changes in cloud-based load balancers for DBaaS scenarios. Closes cloudnative-pg#4922 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Sam Toxopeus <sam@fuga.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
updateStrategyfield to control how the operator updates a service definition. By default, the operator uses thepatchstrategy, applying changes directly to the service. Alternatively, therecreatestrategy deletes the existing service and recreates it from the template.This is particularly useful to handle changes in cloud-based load balancers for DBaaS scenarios.
Closes #4922