Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: restore the ability to use PVCs as source for a restore #4893

Merged
merged 3 commits into from
Jul 9, 2024
Merged

chore: restore the ability to use PVCs as source for a restore #4893

merged 3 commits into from
Jul 9, 2024

Conversation

mnencia
Copy link
Member

@mnencia mnencia commented Jun 18, 2024 •
edited
Loading

Closes #5030

@github-actions GitHub Actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 labels Jun 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@github-actions GitHub Actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@armru armru assigned mnencia and armru and unassigned armru Jun 21, 2024
@mnencia mnencia marked this pull request as ready for review July 4, 2024 09:42
@mnencia mnencia requested a review from a team as a code owner July 4, 2024 09:42
@mnencia mnencia removed the no-issue label Jul 4, 2024
@mnencia
Copy link
Member Author

mnencia commented Jul 4, 2024

/test d=push

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9796426435

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Jul 4, 2024
@mnencia mnencia assigned leonardoce and unassigned mnencia and armru Jul 5, 2024
mnencia and others added 3 commits July 8, 2024 15:33
@mnencia @leonardoce
chore: restore the ability to use PVCs as source for a restore
d6cb95d 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@armru @leonardoce
chore: review
8060e3e 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@mnencia @leonardoce
fix: unit tests
a107410 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@leonardoce
Copy link
Contributor

The is fine with me. I started a full E2e suite run: https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/9840725538

@leonardoce
Copy link
Contributor

/ok-to-merge E2e were green

@leonardoce leonardoce merged commit a80a546 into main Jul 9, 2024
29 checks passed
@leonardoce leonardoce deleted the dev/vpc-clone branch July 9, 2024 13:06
cnpg-bot pushed a commit that referenced this pull request Jul 9, 2024
@mnencia
chore: restore the ability to use PVCs as source for a restore (#4893)
e30d9bb 
Closes #5030

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit a80a546)
cnpg-bot pushed a commit that referenced this pull request Jul 9, 2024
@mnencia
chore: restore the ability to use PVCs as source for a restore (#4893)
827ade7 
Closes #5030

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit a80a546)
@redbaron
Copy link
Contributor

redbaron commented Aug 1, 2024

Why this PR is not included in 1.23.3 release notes?

@Routhinator
Copy link

Not sure it works?

      bootstrap:
        recovery:
          volumeSnapshots:
            storage:
              name: db-recovery
              kind: PersistentVolumeClaim
              apiGroup: v1

Is this not approximately what the code should expect?

Rejects it with the error in the PR so it's got this commit.

│ Error: cannot patch "nextcloud-db" with kind Cluster: admission webhook "vcluster.cnpg.io" denied the request: Cluster.cluster.cnpg.io "nextcloud-db" is invalid: spec.bootstrap.recovery.storage: Invalid value: v1.TypedLocalObjectReference{APIGroup:(*string)(0xc001291a00), Kind:"PersistentVolumeClaim", Name:"db-recovery"}: Only VolumeSnapshots and PersistentVolumeClaims are supported

Based on my read of the code, that's what it should be expecting.

samtoxie pushed a commit to samtoxie/cloudnative-pg that referenced this pull request Aug 28, 2024
@mnencia @armru @samtoxie
chore: restore the ability to use PVCs as source for a restore (cloud…
12f6128 
…native-pg#4893)

Closes cloudnative-pg#5030

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Sam Toxopeus <sam@fuga.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armru armru armru approved these changes

@leonardoce leonardoce leonardoce approved these changes

Assignees

@leonardoce leonardoce

Labels
backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.22 release-1.23
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chore]: restore the possibility to use PVCs as recovery source
6 participants
@mnencia @leonardoce @redbaron @Routhinator @armru @cnpg-bot