-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade utility scripts to Python 3 #1056
Comments
I second this - I recently installed Ubuntu 18 and it comes with Python 3 and not 2 (I can install Python 2 as well, but IMO it would not be advisable). |
Hi! I submitted a patch with a few changes to all the files listed in I was wondering if the files in |
@BassMatt thanks for the patch. Please address the minor issues others pointed on the mailing list and we will apply it. |
Main scripts in scripts/ folder updated to use Python3 I went through the scripts detailed in scripts/README and updated them to use Python3. I used the Python "Future" module to provide suggestions, then manually went through and applied the changes. The "Future" module gives suggestions to allow for cross-compatibility between Python2/3, but since it was expressed that only Python3 needed to be supported, I left all that out. The issue is detailed here: cloudius-systems#1056 Message-Id: <20191212200248.12048-1-bassmatt0515@gmail.com>
Following python files have been identified as 'in use' or deemed as possibly useful in the near future:
|
This patch incorporates changes from original patch submitted by Matt Bass as well as extra changes made by Waldemar Kozaczuk to upgrade python scripts from version 2 to version 3. Some trivial changes are the result of automated upgrade tools like "Future" module or 2to3. Others involving proper handling of binary and string data especially when using subprocess module have been manually made. Same goes for any code that tried to compare non-uniform data which python 3 is more strict. Most of the scripts have been tested but there maybe be scenarios/flows which have been missed. Ref #1056 Signed-off-by: Matt Bass <bassmatt0515@gmail.com> Signed-off-by: Waldemar Kozaczuk <jwkozaczuk@gmail.com>
This is the second batch of the python 3 upgrade changes. This one focuces on httpserver API unit tests and most changes revolve around changes to urllib.* modules. The scripts have been tested by runnin following tests in the root of the modules/httpserver-api directory: - make check-http - make check-ssl Ref #1056 Signed-off-by: Waldemar Kozaczuk <jwkozaczuk@gmail.com>
Given the Python end-of-life scheduled for Jan 1st, 2020, we should upgrade at least the key scripts (setup.py, module.py, test.py, etc) under script to be Python 3 compatible.
Please see https://docs.python.org/3/howto/pyporting.html
The text was updated successfully, but these errors were encountered: