Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpserver should not use boost::program_options #1053

Closed
nyh opened this issue Sep 26, 2019 · 0 comments
Closed

httpserver should not use boost::program_options #1053

nyh opened this issue Sep 26, 2019 · 0 comments

Comments

@nyh
Copy link
Contributor

nyh commented Sep 26, 2019

modules/httpserver-api uses boost::program_options to do some trivial option parsing that could have easily been done using getopt_long (see how we did that for another small utility, cpiod.so, in #980).

As explained in #1040, we can no longer assume that the OSv exports the program_options symbols, so httpserver will now need to come with a copy of libboost_program_options.so, which both complicates its manifest and adds about 1MB to the size of the image. But either easier than doing that (adding this .so to the image), we can simply stop using boost::program_options there.

wkozaczuk added a commit to wkozaczuk/osv that referenced this issue Oct 3, 2019
…functions

Fixes cloudius-systems#1053

Signed-off-by: Waldemar Kozaczuk <jwkozaczuk@gmail.com>
@nyh nyh closed this as completed in c08cebc Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant