Fix lodash.clonedeep module issue and add module key to package.json #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copy lodash.clonedeep to a file instead of importing it - Add a module key to package.json - Fix various linting issues (Delete unused lines, add missing return types)
patrick-tolosa
commented
Sep 2, 2021
| @@ -33,16 +31,6 @@ class CloudinaryConfig { | |||
| return this; | |||
| } | |||
|
|
|||
| setAPIConfig(apiConfig: IApiConfig): this { | |||
| // placeholder | |||
There was a problem hiding this comment.
This was added as a placeholder but was never used.
patrick-tolosa
commented
Sep 2, 2021
| @@ -11,5 +11,6 @@ | |||
| }, | |||
| "main": "./bundles/umd/base.js", | |||
| "browser": "./index.js", | |||
| "module": "./index.js", | |||
There was a problem hiding this comment.
Module is used by some build tools instead of main to correctly infer where the ESM code lives.
ghost
approved these changes
Sep 5, 2021
| * _.isObjectLike(null); | ||
| * // => false | ||
| */ | ||
| function isObjectLike(value) { |
There was a problem hiding this comment.
Seeing as we already have an isObject function, and this file includes an isObject and this util and others, maybe we should move such functions to their own file and import here.
There was a problem hiding this comment.
We could but I wouldn't change this specific file, as it's an exact copy of lodash (we could potentially introduce new bugs by changing the implementation.
what do you think?
strausr
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for @cloudinary/url-gen
What does this PR solve?
... A few words
Final checklist