Skip to content

fix v1 url generation to correctly support border objects and strings #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 27, 2021
Merged

fix v1 url generation to correctly support border objects and strings #384

merged 3 commits into from
Apr 27, 2021

Conversation

patrick-tolosa
Copy link
Contributor

Pull request for @Cloudinary/Base

What does this PR solve?

fix v1 URL generation to correctly support border objects and strings.

Final checklist

  • Implementation is aligned to V1
  • Tests - Add proper tests to the added code.

@patrick-tolosa patrick-tolosa requested review from strausr and a user April 26, 2021 07:56
@patrick-tolosa patrick-tolosa merged commit 2017aab into master Apr 27, 2021
@patrick-tolosa patrick-tolosa deleted the fix/v1-url-generation-border-support branch April 27, 2021 20:01
@patrick-tolosa patrick-tolosa mentioned this pull request May 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strausr strausr strausr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrick-tolosa @strausr