Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge UAT down to master #49

Merged
merged 64 commits into from
Mar 30, 2020
Merged
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
63a5822
Use proper source of InspectorControls rather than importing it at th…
dugajean Jan 24, 2020
84595e4
Change the 'Learn more' link href
kienstra Jan 24, 2020
2133a20
Merge pull request #37 from cloudinary/update/learn-more-href
dugajean Jan 24, 2020
87ded83
Ensure that 'media' is available by wrapping the component with withS…
dugajean Jan 24, 2020
b436754
Use proper React practices on component naming and refactor
dugajean Jan 24, 2020
0d7fd4b
Minor refactoring and code formatting on video.js
dugajean Jan 27, 2020
d994a05
Remove redundant check in Filter class; Reformat video.js further
dugajean Jan 28, 2020
3fc7acf
Add transformations to response if attachment has such postmeta avail…
dugajean Jan 28, 2020
2bb75fc
Build assets for production
dugajean Jan 28, 2020
a46f4ac
Fix whitespace and tabs
dugajean Jan 28, 2020
08f9a6c
Implement requested changes: Formatting, minor refactors
dugajean Jan 29, 2020
b10ed5d
Fix display "Overwrite Transformations" checkbox in Classic Editor
dugajean Jan 29, 2020
a7a8746
Fix minor formatting problems & add extra check in media endpoint
dugajean Jan 29, 2020
6906bd0
Whitespace fix and move docblock to a better location
dugajean Jan 29, 2020
a5e8a07
Merge pull request #38 from cloudinary/CLOUD-333
kienstra Jan 29, 2020
ef6caaf
Prevent an error in WP 4.9.12, where sanitize_text_field() caused an …
kienstra Jan 30, 2020
4ab7e7e
Merge pull request #39 from cloudinary/fix/error-in-settings
dugajean Jan 30, 2020
5b74ee6
Fix problem where existing tags would not be added to order list
dugajean Jan 31, 2020
dae89de
Reformat code; Prevent existing tax item from being added twice
dugajean Jan 31, 2020
d42b7d8
Restructure list item ids for consistency; Takes format of "tax:id"
dugajean Jan 31, 2020
7859375
Change structure of keys consistenly in pre-render; Apply changes to CE
dugajean Jan 31, 2020
72c3a83
Wrap up the logic to put/remove tags from the order box
dugajean Jan 31, 2020
ea0dc08
General code reformat
dugajean Jan 31, 2020
2acf091
Handle adding and removing non-database tags in CE
dugajean Jan 31, 2020
ae4e62a
Build assets for production and remove debug code
dugajean Jan 31, 2020
403c2e0
Adhere to coding standards
dugajean Jan 31, 2020
1bd0bd9
Implement minor improvements
dugajean Feb 4, 2020
7c6c27a
Manually apply global video transforms to url onload
dugajean Feb 5, 2020
0f7e5b9
Add overflow: hidden to prevent controls going out of bound
dugajean Feb 5, 2020
6d79654
Prevent variable collision in js
dugajean Feb 5, 2020
cba0823
Adjust code to avoid multiple window.onload calls
dugajean Feb 6, 2020
33a765f
Reformat generated JS
dugajean Feb 6, 2020
032c945
Escape javascript output appropriately and make code more readable
dugajean Feb 7, 2020
5cb9a95
Prevent code duplication and utilize loops instead
dugajean Feb 7, 2020
7739304
Remove redundant PHP tags
dugajean Feb 7, 2020
fd2918d
Indent the first line to the level of the php code
dugajean Feb 7, 2020
369556f
Remove unused method that wraps JS in an onload handler
dugajean Feb 7, 2020
42831d2
Rename vars to prevent global variable name collisions
dugajean Feb 7, 2020
716bcd5
Indents JS back to the PHP level
dugajean Feb 7, 2020
2947754
Merge pull request #42 from cloudinary/cloudinary-videoplayer-resize-bug
kienstra Feb 7, 2020
60c4181
Stretch video to 100% width of the container rather than 300px
dugajean Feb 11, 2020
e8d6abf
Merge pull request #43 from cloudinary/bug/cut-video-bug
Feb 11, 2020
7b7343a
Merge pull request #41 from cloudinary/taxonomy-order
Feb 11, 2020
9cec5ff
bump version
DavidCramer Feb 11, 2020
5f88504
default root folder
DavidCramer Feb 13, 2020
8cd6b12
Merge pull request #44 from cloudinary/fix/CLOUD-346
Feb 13, 2020
c1093cd
merge dev
DavidCramer Feb 13, 2020
50d8822
check limit bitrate is on
DavidCramer Feb 18, 2020
026ed89
Make terms order use take names, then convert on save for reliability
DavidCramer Feb 18, 2020
247c5b8
remove width 100%
DavidCramer Feb 18, 2020
0ffe018
remove default and required for folder
DavidCramer Feb 18, 2020
156588f
be sure folder exists as a value
DavidCramer Feb 18, 2020
4ef3610
rebuild asserts
DavidCramer Feb 19, 2020
72305c1
update bugs for UAT
DavidCramer Feb 19, 2020
2324221
add file name for src
DavidCramer Feb 27, 2020
a5375d3
version bump
DavidCramer Mar 6, 2020
63a9750
do a content search and update after up sync
DavidCramer Mar 19, 2020
919b7ba
Merge pull request #45 from cloudinary/fix/CLOUD-368
dugajean Mar 24, 2020
cba76a4
add test package plugin
DavidCramer Mar 25, 2020
1bcf86e
Merge pull request #46 from cloudinary/feature/test-package
Mar 25, 2020
416f1cb
ensure a video is synced before trying to use metadata
DavidCramer Mar 25, 2020
211ae52
Merge pull request #47 from cloudinary/fix/CLOUD-371
dugajean Mar 25, 2020
200a451
remove classed based editor overwrite flag and filter based on attrib…
DavidCramer Mar 26, 2020
7913824
Merge pull request #48 from cloudinary/fix/CLOUD-370
dugajean Mar 26, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Escape javascript output appropriately and make code more readable
  • Loading branch information
dugajean committed Feb 7, 2020
commit 032c945dab3986bfa073b8a76e24e8a6046956f3
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ public function print_video_scripts() {
}

$code[] = sprintf(
"var video%1\$s = cld.videoPlayer( \"cloudinary-video-%1\$s\", %2\$s );\n",
'var video%1$s = cld.videoPlayer( "cloudinary-video-%1$s", %2$s );' . "\n",
$instance,
wp_json_encode( $config )
);
Expand All @@ -355,7 +355,7 @@ public function print_video_scripts() {
if ( isset( $this->config['video_freeform'] ) ) {
$onload_code[] = sprintf(
'
var videoContainer%1$s = document.getElementById( video%s.videojs.id_ );
var videoContainer%1$s = document.getElementById( video%1$s.videojs.id_ );
var videoElement%1$s = videoContainer%1$s.getElementsByTagName( "video" );

if ( videoElement%1$s.length === 1 ) {
Expand All @@ -367,8 +367,8 @@ public function print_video_scripts() {
}
}
',
$instance,
$this->config['video_freeform']
esc_attr( $instance ),
esc_attr( $this->config['video_freeform'] )
);
}
}
Expand All @@ -391,7 +391,7 @@ public function print_video_scripts() {
* @return string
*/
protected function window_onload_wrapper( $code ) {
return $code ? "\nwindow.onload = function () { {$code} }" : '';
return $code ? "\nwindow.addEventListener( 'load', function () { {$code} });" : '';
}

/**
Expand Down