Fix taxonomy order issues with arranging, memorizing order, adding, removing etc. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved Hi @dugajean, From a functionality perspective, I don't have enough context. But like you mentioned, this could use thorough QA. |
kienstra
approved these changes
Feb 3, 2020
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/terms_order.js
Outdated
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/terms_order.js
Show resolved
Hide resolved
...mage-management-and-manipulation-in-the-cloud-cdn/php/media/class-global-transformations.php
Outdated
Show resolved
Hide resolved
...mage-management-and-manipulation-in-the-cloud-cdn/php/media/class-global-transformations.php
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/terms_order.js
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/terms_order.js
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/terms_order.js
Show resolved
Hide resolved
|
Thanks Ryan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a ton of problems with the taxonomy order box, both in Classic Editor and Block Editor.
These are the bugs that were reported + the ones that I detected:
post_tag:tag_slug)This PR solves all the bugs and attempts to bring in consistency across the code, including the naming as mentioned above.
@kienstra Could you please review this PR when you have some time? It could still have some problem that I might not be seeing as I've made a lot of changes. I think it'd be good to do QA on this one.