Prevent an error in WP 4.9.12 from field sanitization

[kienstra]

Steps to reproduce

1. wp core update --version=4.9.12 --force
2. Switch to PHP 7.3 if you can
3. Go to /wp-admin/admin.php?page=cld_global_transformation&tab=global_video_transformations
4. Expected: The settings appear
5. Actual: there's a PHP error:

Recoverable fatal error: Object of class Closure could not be converted to string in /Users/ryankienstra/Projects/sites/sitio/wp-includes/formatting.php on line 1045

Background

This error is from:

cloudinary_wordpress/cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-settings-page.php

Line 415 in 9b10a98

array_walk_recursive( $field, 'sanitize_text_field' );

One of the values that is passed to sanitize_text_field() is:

sanitize_text_field passes that to _sanitize_text_fields(). That's not a problem in WP 5.0+, I think. It now exits for values like closures.

But in WP 4.9, it didn't yet check the type, and it caused the error here.

This PR should back-port the WP 5.0 functionality to 4.9. There's no expected change in behavior in WP 5.0+.

But this could use good regression testing on the 'Global Transformations' screens, like at /wp-admin/admin.php?page=cld_global_transformation&tab=global_video_transformations

[kienstra]

Request For Review

Hi @dugajean,
Hope you're doing great today. Could you please review this when you have a chance?

Thanks, Dugi!

[parabrola]

Looks very good! Thanks Ryan 😄

[kienstra]

Thanks, Dugi!