Skip to content

Optimizing the query_relations long query #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Develop: 3.2.14
merged 2 commits into from
Sep 29, 2025
Merged

Optimizing the query_relations long query #1099

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a931f7d
Prepare chunks
aatanasovdev Sep 17, 2025
3061cff
Prepare the query to be less than 1024 characters
aatanasovdev Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 44 additions & 30 deletions php/class-utils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,19 +1009,16 @@ public static function attachment_url_to_postid( $url ) {
* @return array
*/
public static function query_relations( $public_ids, $urls = array() ) {
global $wpdb;

$wheres = array();
$searched_things = array();
$chunk_size = 25;
$results = array();
$tablename = self::get_relationship_table();

/**
* Filter the media context query.
*
* @hook cloudinary_media_context_query
* @since 3.2.0
*
* @param $media_context_query {string} The default media context query.
*
* @return {string}
*/
$media_context_query = apply_filters( 'cloudinary_media_context_query', 'media_context = %s' );
Expand All @@ -1031,43 +1028,60 @@ public static function query_relations( $public_ids, $urls = array() ) {
*
* @hook cloudinary_media_context_things
* @since 3.2.0
*
* @param $media_context_things {array} The default media context things.
*
* @return {array}
*/
$media_context_things = apply_filters( 'cloudinary_media_context_things', array( 'default' ) );

// Query for urls in chunks.
if ( ! empty( $urls ) ) {
// Do the URLS.
$list = implode( ', ', array_fill( 0, count( $urls ), '%s' ) );
$where = "(url_hash IN( {$list} ) AND {$media_context_query} )";
$searched_things = array_merge( $searched_things, array_map( 'md5', $urls ), $media_context_things );
$wheres[] = $where;
$results = array_merge( $results, self::run_chunked_query( 'url_hash', $urls, $chunk_size, $tablename, $media_context_query, $media_context_things ) );
}
// Query for public_ids in chunks.
if ( ! empty( $public_ids ) ) {
// Do the public_ids.
$list = implode( ', ', array_fill( 0, count( $public_ids ), '%s' ) );
$where = "(public_hash IN( {$list} ) AND {$media_context_query} )";
$searched_things = array_merge( $searched_things, array_map( 'md5', $public_ids ), $media_context_things );
$wheres[] = $where;
$results = array_merge( $results, self::run_chunked_query( 'public_hash', $public_ids, $chunk_size, $tablename, $media_context_query, $media_context_things ) );
}

$results = array();

if ( ! empty( array_filter( $wheres ) ) ) {
$tablename = self::get_relationship_table();
$sql = "SELECT * from {$tablename} WHERE " . implode( ' OR ', $wheres );
$prepared = $wpdb->prepare( $sql, $searched_things ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
$cache_key = md5( $prepared );
$results = wp_cache_get( $cache_key, 'cld_delivery' );
if ( empty( $results ) ) {
$results = $wpdb->get_results( $prepared, ARRAY_A );// phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.DirectDatabaseQuery.DirectQuery
wp_cache_add( $cache_key, $results, 'cld_delivery' );
return $results;
}
/**
* Run a chunked query and merge results.
*
* @param string $field The DB field to query (url_hash or public_hash).
* @param array $items The items to query.
* @param int $chunk_size Number of items per chunk.
* @param string $tablename The table name.
* @param string $media_context_query The media context SQL.
* @param array $media_context_things The media context values.
* @return array
*/
protected static function run_chunked_query( $field, $items, $chunk_size, $tablename, $media_context_query, $media_context_things ) {
global $wpdb;

$all_results = array();
$chunks = array_chunk( $items, $chunk_size );

foreach ( $chunks as $chunk ) {
$list = implode( ', ', array_fill( 0, count( $chunk ), '%s' ) );
$where = "({$field} IN( {$list} ) AND {$media_context_query} )";
$searched_things = array_merge( array_map( 'md5', $chunk ), $media_context_things );
$sql = "SELECT * from {$tablename} WHERE {$where}";
$prepared = $wpdb->prepare( $sql, $searched_things ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
$cache_key = md5( $prepared );
$chunk_results = wp_cache_get( $cache_key, 'cld_delivery' );

if ( empty( $chunk_results ) ) {
$chunk_results = $wpdb->get_results( $prepared, ARRAY_A ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.DirectDatabaseQuery.DirectQuery

wp_cache_add( $cache_key, $chunk_results, 'cld_delivery' );
}

if ( ! empty( $chunk_results ) ) {
$all_results = array_merge( $all_results, $chunk_results );
}
}

return $results;
return $all_results;
}

/**
Expand Down