Fix the feature to disable additional assets #1084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the feature to disable additional assets.
Approach
When using the toggle and clicking “Apply Changes”, the Cloudinary plugin calls the
disable_cache_itemsREST API endpoint via AJAX.The implementation of this API endpoint had a typo where it was looking for the existing
assetas apost_stateinstead of async_type, resulting in the UPDATE SQL query not updating anything.After fixing that, there was still a need to:
QA Notes