Skip to content

Fix webm audio files #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2025
Merged

Fix webm audio files #1080

merged 2 commits into from
Sep 2, 2025

Conversation

@aatanasov-cloudinary
Copy link
Collaborator

Fixes webm files that have only audio.

Approach

  • If videos are delivered, we check the mime type of the video.
  • If it is audio/webm, we don't require width and height.

QA notes

  • Upload a webm file that has only audio.
  • Ensure the file is synced.

gabrielcld2
gabrielcld2 approved these changes Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@gabrielcld2 gabrielcld2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 working as expected

@aatanasov-cloudinary aatanasov-cloudinary merged commit 42da01f into develop Sep 2, 2025
3 checks passed
This was referenced Sep 2, 2025
Merged
Merged
@aatanasov-cloudinary aatanasov-cloudinary deleted the fix-audio-webm-files branch September 17, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielcld2 gabrielcld2 gabrielcld2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aatanasov-cloudinary @gabrielcld2 @aatanasovdev