Skip to content

Comments

Fixed an issue on locales that use a comma as decimal separator#71

Merged
tocker merged 1 commit intocloudinary:masterfrom
jtabet:fix-floats-issue
Apr 3, 2017
Merged

Fixed an issue on locales that use a comma as decimal separator#71
tocker merged 1 commit intocloudinary:masterfrom
jtabet:fix-floats-issue

Conversation

@jtabet
Copy link
Contributor

@jtabet jtabet commented Mar 23, 2017

If you are using a locale that has a comma as decimal separator, it breaks the url generation. The purpose of this pull request is to fix this issue.
Example:

cloudinary_url('my_pic', ['zoom' => 0.7]);
// Result: http://res.cloudinary.com/xxx/image/upload/z_0,7/my_pic.jpg
// Should be: http://res.cloudinary.com/xxx/image/upload/z_0.7/my_pic.jpg

@tocker tocker merged commit 483de4a into cloudinary:master Apr 3, 2017
@tocker
Copy link
Contributor

tocker commented Apr 3, 2017

@jtabet thanks for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants