Add support of "auto" value for start_offset transformation parameter#123
Merged
const-cloudinary merged 2 commits intomasterfrom Jun 26, 2018
Merged
Add support of "auto" value for start_offset transformation parameter#123const-cloudinary merged 2 commits intomasterfrom
start_offset transformation parameter#123const-cloudinary merged 2 commits intomasterfrom
Conversation
const-cloudinary
requested changes
Jun 4, 2018
tests/CloudinaryTest.php
Outdated
| $this->assertNull($method->invoke(null, "")); | ||
| $this->assertNull($method->invoke(null, null)); | ||
| // shouldn't support "auto" value | ||
| $this->assertNull($method->invoke(null, "auto"), "auto"); |
Contributor
There was a problem hiding this comment.
last "auto" in this function is a message for assertNull. If you want to add custom message, make it more verbose. If it is a mistake, just remove it.
tests/CloudinaryTest.php
Outdated
| { | ||
| $method = new ReflectionMethod('Cloudinary', 'norm_auto_range_value'); | ||
| $method->setAccessible(true); | ||
| $pairs = [ |
Contributor
There was a problem hiding this comment.
You can reuse this array in test_norm_range_value.
Now we have 2 pretty much identical tests written in completely different manner. Which is confusing.
The solution you provided is much better than test_norm_range_value, it would be great to refactor it as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.