Add srcset and sizes attributes to the img tag#117
Merged
const-cloudinary merged 12 commits intomasterfrom May 3, 2018
Merged
Conversation
Helper function that also clones objects
Refactor/improve unit tests
const-cloudinary
force-pushed
the
feature/add-srcset-to-cl-image-tag
branch
from
2ad3d32 to
0732165
Compare
const-cloudinary
commented
May 3, 2018
| } | ||
|
|
||
| /** | ||
| * @internal Helper function. Generates sizes attribute value of the HTML img tag |
Contributor
Author
There was a problem hiding this comment.
TODO: Update PHPDoc
| } | ||
|
|
||
| /** | ||
| * Generates HTML img tag |
Contributor
Author
There was a problem hiding this comment.
TODO: Update PHPDoc
| } | ||
|
|
||
| /** | ||
| * @internal Helper function. Generates srcset attribute value of the HTML img tag |
Contributor
Author
There was a problem hiding this comment.
TODO: Update PHPDoc
| } | ||
|
|
||
| /** | ||
| * @internal Helper function. Generates a single srcset item url |
Contributor
Author
There was a problem hiding this comment.
TODO: Update PHPDoc
| function cl_image_tag($source, $options = array()) | ||
|
|
||
| /** | ||
| * @internal Helper function. Gets or populates srcset breakpoints using provided parameters |
Contributor
Author
There was a problem hiding this comment.
TODO: Update PHPDoc
const-cloudinary
added a commit
that referenced
this pull request
Jul 14, 2020
* Add doc strings for classes. * Transformations: StreamingProfile to Volume (Meir) * Add doc strings to various transformation classes. * Update transformation strings. * Add strings for SmartObject and Palette classes. * Apply suggestions from Caroline's code review * Add transformation guide link to Opacity class description. * Fix docs .gitignore file * Fix maximum line length warning * Add Tag class doc strings. * Update following review. * Update following review. * Improve tag samples * Update description. Co-authored-by: Nick Bradley <nick.bradley@cloudinary.com> Co-authored-by: Meir Feinberg <meir.feinberg@cloudinary.com> Co-authored-by: Caroline Levison <caroline.levison@cloudinary.com> Co-authored-by: Constantine Nathanson <constantine@cloudinary.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.