Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dependency on Q #666

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

talentlessguy
Copy link

Brief Summary of Changes

This PR removes a deprecated and outdated Promise library - Q. And replaces it with Promise API and built-ins.

deprecation notice from q:

You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other. (For a CapTP with native promises, see @endo/eventual-send and @endo/captp)

The source now uses the following methods:

  • new Promise() - supported since Node 0.12 and in all browsers (except IE11)
  • Promise.resolve - same as above
  • Promise.reject - same as above

What Does This PR Address?

  • GitHub issue (Add reference - #XX)
  • Refactoring
  • New feature
  • Bug fix
  • Adds more tests

Are Tests Included?

  • Yes
  • No, the tests logic didn't change

@cloudinary-pkoniu
Copy link
Contributor

@talentlessguy PR looks great, thank you for your contribution. Can you please pull latest master? There are some fixes to the CI that need to be included before we can merge.

@talentlessguy
Copy link
Author

@cloudinary-pkoniu sure thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants