Add create folder API #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asisayag2
reviewed
Nov 27, 2019
| @@ -46,6 +46,7 @@ | |||
| public static final Transformation DELETE_TRANSFORMATION = new Transformation().width(100).crop("scale").overlay(new TextLayer().text(SUFFIX + "_delete").fontFamily("Arial").fontSize(60)); | |||
| public static final String TEST_KEY = "test-key" + SUFFIX; | |||
| public static final String API_TEST_RESTORE = "api_test_restore" + SUFFIX; | |||
| public static final Set<String> createdFolders = new HashSet<String>(); | |||
There was a problem hiding this comment.
@michalkcloudinay , you only create a single folder with a known name in your test("api_test_create_folder" + "_" + SUFFIX), why you need to store a Set?
There was a problem hiding this comment.
@asisayag2 In order to support additional functions (in the future) where we create folders. All folders will be added to this set and will be deleted in one command when cleaning up.
There was a problem hiding this comment.
@michalkcloudinay , not needed right now.
Lean approach... we add what we need, and the next test that creates a folder will refactor to handle >1 folders.
@nitzanj , WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.