Skip to content

Generate https urls by default when running on Android 9 and above. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Generate https urls by default when running on Android 9 and above. #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/src/main/java/com/cloudinary/android/MediaManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import android.app.Application;
import android.content.Context;
import android.net.Uri;
import android.os.Build;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.view.View;
Expand Down Expand Up @@ -226,7 +227,15 @@ public Cloudinary getCloudinary() {
* Get a Cloudinary Url object used to construct urls to access and transform pre-uploaded resources.
*/
public Url url() {
return cloudinary.url();
Url url = cloudinary.url();

// set https as default for android P and up - in P the default policy fails all http
// requests
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
url.secure(true);
}

return url;
}

/**
Expand Down