Skip to content

Add fully-automatic mode to the Upload Widget #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2020

Conversation

nitzanj
Copy link
Contributor

@nitzanj nitzanj commented Apr 20, 2020

No description provided.

@@ -41,16 +38,13 @@ public static void setup() throws IOException {
public IntentsTestRule<MainActivity> intentsTestRule = new IntentsTestRule<>(MainActivity.class);

// TODO: Fix UI tests for travis
@Ignore
// @Ignore

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test or the annotation? or the comment ? what state do you want this part to be in master?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment

intending(hasComponent(MockNativePickerActivity.class.getName())).respondWith(result);
intentsTestRule.getActivity().startActivityForResult(new Intent(intentsTestRule.getActivity(), MockNativePickerActivity.class), MainActivity.CHOOSE_IMAGE_REQUEST_CODE);

UploadWidget.startActivity(intentsTestRule.getActivity(),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test the other options?

@nitzanj nitzanj merged commit f252467 into master May 13, 2020
@nitzanj nitzanj deleted the feature/self-contained-upload-widget branch May 13, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants