Skip to content

Conversation

@YomesInc
Copy link
Contributor

Brief Summary of Changes

<Video> now supports the sources property:

<Video
  cloudName='demo'
  publicId='dog'
  sources={[
    {
      type: 'mp4',
      codecs: ['vp8', 'vorbis'],
      transformations: {
        videoCodec: 'auto'
      }
    },
    {
      type: 'webm',
      codecs: ['avc1.4D401E', 'mp4a.40.2'],
      transformations: {
        videoCodec: 'auto'
      }
    }
  ]}
/>

What does this PR address?

  • New feature

Are tests included?

  • Yes

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all of the tests pass.

@YomesInc YomesInc requested a review from a user January 21, 2021 19:47
@patrick-tolosa
Copy link
Contributor

@maoznir Please note the build is failing, it looks like react is not a dependency of this project (it should probably be a devDependency).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants