Fix/dont rename non cloudinary props #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
patrick-tolosa
approved these changes
Jul 16, 2020
asisayag2
approved these changes
Jul 16, 2020
asisayag2
reviewed
Jul 16, 2020
| if (!isInView && this.shouldLazyLoad(options)) { | ||
| attributes.dataSrc = attributes.dataSrc || attributes.src; | ||
| attributes['data-src'] = attributes.dataSrc || attributes.src; |
There was a problem hiding this comment.
@maoznir , why do we need this line AND lines 61-64?
| const {cloudinaryProps, cloudinaryReactProps, nonCloudinaryProps} = extractCloudinaryProps(options); | ||
| options = {...cloudinaryProps, ...cloudinaryReactProps}; | ||
|
|
||
| //const snakeCaseOptions = toSnakeCaseKeys(options); |
Comment on lines
+82
to
+83
| let tagAttributes = cld.videoTag(publicId, options).attributes(); | ||
| tagAttributes = {...Util.withCamelCaseKeys(tagAttributes), ...nonCloudinaryProps}; |
There was a problem hiding this comment.
You have the cloudinary+react props in options and the non-cloudinary props in nonCloudinaryProps, why do we need to create a tag for getting those tagAttributes?
| @@ -94,6 +94,14 @@ describe('Image', () => { | |||
|
|
|||
| expect(tag.find('img').prop('src')).to.match(/fn_wasm:blur.wasm\/sample/); | |||
| }); | |||
| it('should not change kebab-case param names', () => { | |||
There was a problem hiding this comment.
it('should not change kebab-case for non-cloudinary param names', () => {
| ); | ||
|
|
||
| expect(tag.find('img').prop('data-testid')).to.equal('testing'); | ||
| expect(tag.find('img').prop('datatestid')).to.equal(undefined); |
| @@ -190,4 +190,13 @@ describe('Video', () => { | |||
| expect(video.prop('plays_inline')).to.equal(undefined); | |||
| expect(video.prop('auto_play')).to.equal(undefined); | |||
| }); | |||
| it('should not change kebab-case param names', () => { | |||
There was a problem hiding this comment.
it('should not change kebab-case for non-cloudinary param names', () => {
|
|
||
| const video = tag.find('video'); | ||
| expect(video.prop('data-testid')).to.equal("testing"); | ||
| expect(video.prop('datatestid')).to.equal(undefined); |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.