Fix test issue for Node 10

[calebeby]

This PR closes #63

The tests were not passing because this issue was showing up: nodejs/node#20281

For some reason it was solved by regenerating the lockfile (the bug must have been fixed in a minor version bump of a dependency)

Validation Steps

git checkout master

npm i # (this will also run the tests)

The clean test will fail.

git checkout fix-node-10

npm i # (this will also run the tests)

The tests should pass

[gerardo-rodriguez]

Thanks @calebeby! May I offer a friendly suggestion? :)

To help understand which specific GH issue this PR closes, could you use a GH "close" keyword as part of your summary/description?

Something like:

This PR closes #14 by...

Thank you! 😄

[gerardo-rodriguez]

Closes #63

@calebeby Ha! Looks like you beat me to it. Thank you! 😉

[gerardo-rodriguez]

@calebeby One more suggestion, if I may. :)

We started doing this in another project, but could you provide some steps to validate the fix? Something like:

Validation Steps

1. Do a thing

2. Do this next thing

3. Confirm xyz

This will help me greatly as I switch between project contexts. 😅 Thank you! 😉

[calebeby]

@gerardo-rodriguez Updated ✅

[gerardo-rodriguez]

Updated

Thanks @calebeby!! Very much appreciated! 😄

I just checked out master but the install step is failing for me in the validation steps. 😕

$ npm i
npm WARN The package postcss-class-prefix is included as both a dev and production dependency.

npm ERR! Cannot read property '0' of undefined

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/Rodriguez/.npm/_logs/2018-06-22T19_35_22_338Z-debug.log

🙊

This seems like a different issue. @tylersticka @megnotarte @derekshirk Does this happen to anyone else? 🤔

[gerardo-rodriguez]

npm WARN The package postcss-class-prefix is included as both a dev and production dependency.

@calebeby and I agreed to open a new PR (#65) to fix this.

[gerardo-rodriguez]

@calebeby Both the master and the fix-node-10 branch clean tests pass for me.

$ node -v
v9.11.2

On master:

  clean task

    ✔ Cleans up files and folders

  copy task

    ✔ Copies asset files

  css task

    ✔ Processes CSS files

  html task

    ✔ Compiles Handlebars templates

  js task

    ✔ Transpiles and resolves dependencies


  total:     5
  passing:   5
  duration:  8s

On the fix-node-10 branch:

  clean task

    ✔ Cleans up files and folders

  copy task

    ✔ Copies asset files

  css task

    ✔ Processes CSS files

  html task

    ✔ Compiles Handlebars templates

  js task

    ✔ Transpiles and resolves dependencies


  total:     5
  passing:   5
  duration:  9.3s

Should I be testing on a different node version? 🤔

[calebeby]

@gerardo-rodriguez for me, node 9 works, but node 10 is the one causing the issue. I am using node v10.5.0

[gerardo-rodriguez]

Works like a charm! 🚀