Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refer to JavaPluginConvention for g9 compat #3073

Merged

Conversation

alexanderankin
Copy link
Contributor

@alexanderankin alexanderankin commented Oct 3, 2024

improves gradle 9 compatibility by referring to JavaPlugin properties on the convention rather than on the project directly, avoiding the below warning message:

Build file '~/IdeaProjects/uaa/build.gradle': line 84 The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.10.2/userguide/upgrading_version_8.html#java_convention_deprecation
        at build_c5l1z2riwxqbf7m8y30n581oy$_run_closure2.doCall$original(~/IdeaProjects/uaa/build.gradle:84)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        at build_c5l1z2riwxqbf7m8y30n581oy.run(~/IdeaProjects/uaa/build.gradle:55)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
Build file '~/IdeaProjects/uaa/build.gradle': line 85 The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.10.2/userguide/upgrading_version_8.html#java_convention_deprecation
        at build_c5l1z2riwxqbf7m8y30n581oy$_run_closure2.doCall$original(~/IdeaProjects/uaa/build.gradle:85)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        at build_c5l1z2riwxqbf7m8y30n581oy.run(~/IdeaProjects/uaa/build.gradle:55)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)

improves gradle 9 compatibility by referring to JavaPlugin properties on the convention rather than on the project directly, avoiding the below warning message:

Build file '~/IdeaProjects/uaa/build.gradle': line 84
The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.10.2/userguide/upgrading_version_8.html#java_convention_deprecation
        at build_c5l1z2riwxqbf7m8y30n581oy$_run_closure2.doCall$original(~/IdeaProjects/uaa/build.gradle:84)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        at build_c5l1z2riwxqbf7m8y30n581oy.run(~/IdeaProjects/uaa/build.gradle:55)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
Build file '~/IdeaProjects/uaa/build.gradle': line 85
The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.10.2/userguide/upgrading_version_8.html#java_convention_deprecation
        at build_c5l1z2riwxqbf7m8y30n581oy$_run_closure2.doCall$original(~/IdeaProjects/uaa/build.gradle:85)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        at build_c5l1z2riwxqbf7m8y30n581oy.run(~/IdeaProjects/uaa/build.gradle:55)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
Copy link

linux-foundation-easycla bot commented Oct 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: alexanderankin / name: David Ankin (5e10e98)

@alexanderankin
Copy link
Contributor Author

alexanderankin commented Oct 3, 2024

are there any other considerations around build engineering currently under consideration? i could consider taking a look as currently evaluating whether to use this as a (more recently than keycloak) certified oauth2 provider.

e.g. i noticed a lot of old school task declarations

task someTask() {

and some that dont work, subprojects.all and other things in gradle that could be cleaned up.

additionally, perhaps using libs.versions.toml file may be of interest over the current state - https://docs.gradle.org/current/userguide/platforms.html#sub:conventional-dependencies-toml

@strehle
Copy link
Member

strehle commented Oct 4, 2024

@alexanderankin Thank you for the PR. It brings up an issue we have with codeql scanning... we will fix this and then your PR should be rebase.

If you have further improvements for gradle , please propose

@strehle strehle mentioned this pull request Oct 4, 2024
@strehle strehle closed this in #3075 Oct 5, 2024
@strehle strehle reopened this Oct 5, 2024
@strehle strehle merged commit e0df18f into cloudfoundry:develop Oct 5, 2024
39 of 41 checks passed
@alexanderankin
Copy link
Contributor Author

thanks @strehle will take a look and write up a more detailed issue or pr when I can

@alexanderankin alexanderankin deleted the fix/improve-gradle-9-compat branch October 5, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants