fix: add external saml groups with empty whitelist #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be consistent with external OIDC logins, we should add external SAML groups if the whitelist is empty. Change-Id: I0981440b1986c6ff107ea39d7e141b6eb6b683e5
strehle
approved these changes
Sep 25, 2024
|
Hi Mike, the motivation for this PR is only to be consistent with external OIDC logins or is there a bug associated with it? |
It is mostly to be consistent but the OIDC behavior is also more convenient to specify an empty whitelist than have to provide a regex that matches all groups. |
coolgang123
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: change of behavior.
To be consistent with external OIDC logins, add external SAML groups if the whitelist is empty.