Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update k8s to go 1.20 #2432

Merged
merged 1 commit into from
Aug 1, 2023
Merged

fix: update k8s to go 1.20 #2432

merged 1 commit into from
Aug 1, 2023

Conversation

Tallicia
Copy link
Contributor

@Tallicia Tallicia commented Aug 1, 2023

updated and has updated with go mod tidy.

[#185619304]

@peterhaochen47

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/185741385

The labels on this github issue will be updated when the story is started.

@hsinn0
Copy link
Contributor

hsinn0 commented Aug 1, 2023

The change itself, which has the one-line change in go.mod is as expected. However, there is something wrong with the commit message.

has updated with go mod vendor

go mod vendor would have created vendor folder as it did not exist yet. However, vendor folder is not a part of the commit and it should not be as we do not need/want that for this go module. Just doing go mod tidy was enough for this change. I suggest to remove "go mod vendor" from the commit message.
See https://go.dev/ref/mod#vendoring.

Copy link
Contributor

@hsinn0 hsinn0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment regarding the commit message.

@Tallicia
Copy link
Contributor Author

Tallicia commented Aug 1, 2023

@hsinn0 The requested changes have been made.

@hsinn0
Copy link
Contributor

hsinn0 commented Aug 1, 2023

I see the PR comment updated. However, the commit message was not. Isn't the commit message the one added as commit message after "Rebase and merge"?

    updated and ran go mod tidy.

    [#185619304]

    Co-authored-by: Peter Chen <peterch@vmware.com>
@peterhaochen47 peterhaochen47 merged commit 8083bb3 into develop Aug 1, 2023
17 of 18 checks passed
@peterhaochen47 peterhaochen47 deleted the go-k8s-update branch August 1, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants