Support json key set in tokenKey #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: OIDC IdP trust can be verified using tokenKeyUrl or tokenKey In case of tokenKeyUrl the jwks_uri is called to fetch all current keys in order to verify the JWT signature. In case of tokenKey there is currently only a single key possible. If the IdP has a dynamic key rotation, then trust breaks.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/185243381 The labels on this github issue will be updated when the story is started. |
|
@adrianhoelzl-sap @tack-sap Can you review this change? It allows to paste the configure the whole content of the tokens_keys endpoint as input for attribute "tokenKey", meaning potentially also multiple keys as the structure is JSON. Thanks! |
tack-sap
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: OIDC IdP trust can be verified using tokenKeyUrl or tokenKey In case of tokenKeyUrl the jwks_uri is called to fetch all current keys in order to verify the JWT signature. In case of tokenKey there is currently only a single key possible. If the IdP has a dynamic key rotation, then trust breaks.