fix: Update gem setting to latest slate version #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/184780985 The labels on this github issue will be updated when the story is started. |
strehle
added
ruby
strehle
changed the title
|
@bruce-ricard If the build succeeded locally for you, are we comfortable merging this? |
please do not merge this one .... we need to sync more from slate, e.g. |
Tallicia
added
blocked
strehle
changed the title
|
@Tallicia locally I now see same formatting/content compared to https://docs.cloudfoundry.org/api/uaa, so from my side, please check and then we could finish with this topic |
Tallicia
approved these changes
Apr 25, 2023
strehle
added a commit
that referenced
this pull request
Apr 27, 2023
* fix: Update gem setting to latest slate version * gh checker * revert some bundle versions * locally working now with docker * add bundler 2 dependency to gradle * Update from rouge https://github.com/slatedocs/slate/pull/1226/files
Tallicia
pushed a commit
that referenced
this pull request
Apr 28, 2023
* fix: Update gem setting to latest slate version * gh checker * revert some bundle versions * locally working now with docker * add bundler 2 dependency to gradle * Update from rouge https://github.com/slatedocs/slate/pull/1226/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Gem* to latest vesion from https://github.com/slatedocs/slate , e.g.
https://github.com/slatedocs/slate/blob/main/Gemfile
https://github.com/slatedocs/slate/blob/main/Gemfile.lock
Check of result can be seen with:
docker run --tty --interactive --workdir /root/uaa --volume $PWD:/root/uaa --env DB=hsqldb --rm cfidentity/uaa-generate-docs /root/uaa/scripts/generate-docs.sh
Compare result from ./uaa/uaa/build/docs/....
with
https://docs.cloudfoundry.org/api/uaa/
Currently I see some formatting changes but content is same and it would solve
https://github.com/cloudfoundry/uaa/security/dependabot