Skip to content

Add .manifest.json to list of files indicating local asset precompilation#1006

Merged
robdimsdale merged 1 commit intocloudfoundry:developfrom
rahearn:rails-8-precompiled-assets
Mar 25, 2025
Merged

Add .manifest.json to list of files indicating local asset precompilation#1006
robdimsdale merged 1 commit intocloudfoundry:developfrom
rahearn:rails-8-precompiled-assets

Conversation

@rahearn
Copy link
Contributor

@rahearn rahearn commented Jan 2, 2025

A short explanation of the proposed change:

  • Adds .manifest.json to the list of files that indicate that assets were precompiled locally

An explanation of the use cases your change solves

I'd like to skip any asset handling in the buildpack as I am doing it as part of my CI pipeline. Rails 8 & Propshaft introduced a new manifest file location that the buildpack wasn't yet checking

  • I have viewed signed and have submitted the Contributor License Agreement
  • I have made this pull request to the develop branch
  • I have added an integration unit test

@rahearn rahearn requested a review from a team January 2, 2025 17:17
@robdimsdale robdimsdale merged commit 8f55bc9 into cloudfoundry:develop Mar 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants