Fix and Enhance Session Affinity Tests#533
Merged
ameowlia merged 3 commits intocloudfoundry:developfrom Feb 27, 2026
Merged
Conversation
hoffmaen
changed the title
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
ameowlia
approved these changes
Feb 27, 2026
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Pull-Request fixes a test failure introduced with #530.
The session affinity tests use
MaxAge=1by default. Before #530, positiveMaxAgevalues were ignored and the corresponding__VCAP_ID__cookie had noMaxAge(corresponds toMax-Age=0inhttp.Cookies).After #530, Gorouter applies positive
Max-Agevalues fromJSESSIONIDto__VCAP_ID__, but this test case has been overseen.Removing the default value for
MaxAgein the tests, adding a few test cases, and improving consistency over test cases.Backward Compatibility
Breaking Change? No