Skip to content

Conversation

@breedx-splk
Copy link
Contributor

This framework will wire up the Splunk distribution of OpenTelemetry java for auto-instrumentation and direct ingest. It leverages VCAP_SERVICES and the existence of a service binding with a specific name (splunk-o11y).

Signed-off-by: Jason Plumb jplumb@splunk.com

Resolves issue #825

This framework will wire up the splunk distribution of opentelemetry java for auto-instrumentation and direct ingest. It leverages VCAP_SERVICES and the existence of a service binding with a specific name (splunk-o11y).

Signed-off-by: Jason Plumb jplumb@splunk.com

Resolves issue cloudfoundry#825
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 19, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: breedx-splk / name: jason plumb (7c46b1d)

Copy link
Contributor

@dmikusa dmikusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, much appreciated! A few bits of feedback.

@breedx-splk
Copy link
Contributor Author

Thanks @dmikusa for the review...greatly appreciated. I made some changes and am ready for another look.

@breedx-splk
Copy link
Contributor Author

Hi @dmikusa Just checking back in after a few days. Thanks.

@dmikusa
Copy link
Contributor

dmikusa commented Oct 11, 2022

Apologizes. I don't have access to CF environments at the moment. @pivotal-david-osullivan would need to provide final review & merge.

@breedx-splk
Copy link
Contributor Author

Hi @pivotal-david-osullivan any chance to get a review on this please? 🙏🏻

@pivotal-david-osullivan
Copy link
Contributor

Apologies for the delay, I had some issues getting environments too, I will review and update ASAP!

@breedx-splk
Copy link
Contributor Author

@pivotal-david-osullivan Just touching base again. 🤞🏻 Thanks.

@breedx-splk
Copy link
Contributor Author

Nudging this again to keep this alive.....thanks in advance.

@breedx-splk
Copy link
Contributor Author

Maybe we could get a look before the year is over?

@pivotal-david-osullivan pivotal-david-osullivan merged commit b6e55e5 into cloudfoundry:main Dec 13, 2022
@pivotal-david-osullivan
Copy link
Contributor

I was able to get a lab and test this, the agent downloads and I see some initial output. Thank you for your patience on this @breedx-splk and thanks again for the PR, I've merged it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants