Extension point for supplying an external Tomcat configuration#274
Closed
violetagg wants to merge 1 commit intocloudfoundry:masterfrom
violetagg:tomcat_external_configuration
Closed
Extension point for supplying an external Tomcat configuration#274violetagg wants to merge 1 commit intocloudfoundry:masterfrom violetagg:tomcat_external_configuration
violetagg wants to merge 1 commit intocloudfoundry:masterfrom
violetagg:tomcat_external_configuration
Conversation
|
Hey violetagg! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
|
Contributor
|
I'm happy with the code changes. |
Contributor
|
Resolved with b2bdeb8 |
Contributor
Author
|
Thanks a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to propose an extension point for supplying a Tomcat configuration without forking the buildpack.
The new component is disabled by default and can be enabled in case an external Tomcat configuration will be used.
The mechanism for overlaying the configuration will not be changed.
The external Tomcat configuration must be supplied in TAR format and must follow the Tomcat archive structure.
The external Tomcat configuration will not be modified so the supplier should guarantee that the symlinks are allowed.
I would be glad to hear your opinion.
Thanks,
Violeta