Skip to content

Fixed log statement when expanding Tomcat.#261

Merged
nebhale merged 1 commit intocloudfoundry:masterfrom
violetagg:comment
Nov 30, 2015
Merged

Fixed log statement when expanding Tomcat.#261
nebhale merged 1 commit intocloudfoundry:masterfrom
violetagg:comment

Conversation

@violetagg
Copy link
Contributor

Hi,

In TomEE BP, the TomEE Instance inherits Tomcat Instance [1].

When one invokes "cf push -b https://github.com/cloudfoundry-community/tomee-buildpack"
The following will appear in the command line:

-----> Downloading Tomee Instance 1.7.2 from https://download.run.pivotal.io/tomee/tomee-1.7.2.tar.gz
       Expanding Tomcat to .java-buildpack/tomee

As you can see there is "Expanding Tomcat" which is not correct when using TomEE BP.

With this change I would like to change the log statement in Java BP in a way that even when inherited Tomcat Instance will print the correct name i.e.:

-----> Downloading Tomee Instance 1.7.2 from https://download.run.pivotal.io/tomee/tomee-1.7.2.tar.gz
       Expanding Tomee Instance to .java-buildpack/tomee

What do you think?

Regards,
Violeta
[1] https://github.com/cloudfoundry-community/tomee-buildpack/blob/master/lib/java_buildpack/container/tomee/tomee_instance.rb

@cfdreddbot
Copy link

Hey violetagg!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@nebhale nebhale merged commit 1d46198 into cloudfoundry:master Nov 30, 2015
@violetagg violetagg deleted the comment branch December 8, 2015 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants