Skip to content

Fix installation command in readme #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Dec 9, 2020

The current installation command from project's readme yields the following error:

$ go get -v github.com/cloudfoundry/java-buildpack-memory-calculator/v4
github.com/cloudfoundry/java-buildpack-memory-calculator (download)
package github.com/cloudfoundry/java-buildpack-memory-calculator/v4: cannot find package "github.com/cloudfoundry/java-buildpack-memory-calculator/v4" in any of:
	/usr/lib/go-1.14/src/github.com/cloudfoundry/java-buildpack-memory-calculator/v4 (from $GOROOT)
	/home/vpavic/go/src/github.com/cloudfoundry/java-buildpack-memory-calculator/v4 (from $GOPATH)

Whereas the command from this proposed update results in a clean installation:

$ go get -v github.com/cloudfoundry/java-buildpack-memory-calculator
github.com/spf13/pflag (download)
github.com/cloudfoundry/java-buildpack-memory-calculator/memory
github.com/spf13/pflag
github.com/cloudfoundry/java-buildpack-memory-calculator/flags
github.com/cloudfoundry/java-buildpack-memory-calculator/calculator
github.com/cloudfoundry/java-buildpack-memory-calculator

It seems that the current command is a result of project-wide search & replace that was done in 709ddef.

@linux-foundation-easycla
Copy link

CLA Not Signed

@ekcasey
Copy link
Contributor

ekcasey commented Dec 10, 2020

@vpavic would you mind signing the CLA?

@vpavic
Copy link
Contributor Author

vpavic commented Dec 11, 2020

@ekcasey If it's really necessary, I can.

IMO this is really a trivial change that would fall into the obvious fix category under the Pivotal CLA. Do you have something similar for Cloud Foundry as well?

@ekcasey ekcasey merged commit 5da4b13 into cloudfoundry:main Dec 11, 2020
@vpavic vpavic deleted the fix-install-command branch December 11, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants