Skip to content

Add strip_header to delete headers on the frontend#690

Merged
b1tamara merged 1 commit intocloudfoundry:masterfrom
sap-contributions:feature/add-strip_headers
Jul 22, 2024
Merged

Add strip_header to delete headers on the frontend#690
b1tamara merged 1 commit intocloudfoundry:masterfrom
sap-contributions:feature/add-strip_headers

Conversation

@hoffmaen
Copy link
Contributor

Implement config property strip_headers, which allows to delete configured headers from incoming requests based on the header key.

If both 'strip_headers' and 'headers' contain the same key, the header (if set) is first deleted from the request, and then set to the configured value.

@hoffmaen hoffmaen requested a review from CFN-CI as a code owner July 19, 2024 15:14
@hoffmaen hoffmaen requested a review from a team July 19, 2024 15:14
@hoffmaen hoffmaen marked this pull request as draft July 19, 2024 15:14
@hoffmaen hoffmaen force-pushed the feature/add-strip_headers branch from 1de3425 to 69fd004 Compare July 22, 2024 06:50
@b1tamara b1tamara added the run-ci Allow this PR to be tested on Concourse label Jul 22, 2024
b1tamara
b1tamara previously approved these changes Jul 22, 2024
Copy link
Contributor

@b1tamara b1tamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to run ci

Implement config property strip_headers, which allows to delete configured headers from incoming requests based on the header key.

If both 'strip_headers' and 'headers' contain the same key, the header (if set) is first deleted from the request, and then set to the configured value.
@hoffmaen hoffmaen force-pushed the feature/add-strip_headers branch from 69fd004 to 823f33a Compare July 22, 2024 07:06
@hoffmaen hoffmaen marked this pull request as ready for review July 22, 2024 07:06
Copy link
Contributor

@b1tamara b1tamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to run CI

Copy link
Contributor

@b1tamara b1tamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b1tamara b1tamara merged commit e609980 into cloudfoundry:master Jul 22, 2024
@hoffmaen hoffmaen deleted the feature/add-strip_headers branch February 12, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-ci Allow this PR to be tested on Concourse

Development

Successfully merging this pull request may close these issues.

2 participants