Remove chacha20 cipher #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove chacha20 cipher from cmd/ssh-proxy/main.go file in accordance to SAP security standards in order to prevent vulnerabilities related to terapin attacks. Related BLI: https://jira.tools.sap/browse/CFAR-1064
Remove chacha20 cipher from cmd/sshd/main.go file in accordance to SAP security standards in order to prevent vulnerabilities related to terapin attacks. Related BLI: https://jira.tools.sap/browse/CFAR-1064
|
Related diego release issue: |
Remove chacha20 cipher from tests Related BLI: https://jira.tools.sap/browse/CFAR-1064
Remove chacha20 cipher from tests Related BLI: https://jira.tools.sap/browse/CFAR-1064
ameowlia
approved these changes
Jan 21, 2025
|
FYI - I am going to mark this as a breaking change. |
|
@DimitarSch : The URL https://jira.tools.sap/browse/CFAR-1064 is not accessible for everyone. You could create a github issue instead so that everyone can access the information. |
|
Hi @jochenehret, it was not intended this link to be exposed externally. This is the issue which @DimitarSch opened which apparently also contains the link, but also provides some more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove chacha20 cipher from cmd/ssh-proxy/main.go and cmd/sshd/main.go files in accordance to SAP security standards in order to prevent vulnerabilities related to terapin attacks.
Related BLI: https://jira.tools.sap/browse/CFAR-1064
Changes have been applied and tested on a dev landscape using a custom diego release.