test: de-duplicate plan definitions #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of maintaining plan definitions in the tests, they should be read from the source of truth - the `.envrc` file. This reduces duplication and the tendency for the definitions to drift apart.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/184814890 The labels on this github issue will be updated when the story is started. |
pivotal-marcela-campo
approved these changes
Mar 29, 2023
| @@ -14,16 +14,11 @@ import ( | |||
| var _ = Describe("Redis", Label("redis"), func() { | |||
| When("upgrading broker version", func() { | |||
| It("should continue to work", func() { | |||
| if brokerpaks.DetectBrokerpakV140(releasedBuildDir) { | |||
| Skip("Brokerpak 1.4.0 and earlier no longer can create AWS Redis service instances") | |||
There was a problem hiding this comment.
I am not sure how we are replacing this. Are we skipping somehow differently? Or just getting rid of it as those versions are not longer tested?
There was a problem hiding this comment.
We test the 1.6.0 -> 1.6.1 upgrade currently, so as you say those versions are no longer tested. If we start testing them in the future, we can add the check back quite easily. The current implementation confused me: is it just 1.4.0, 1.4.0 and higher, or 1.4.0 and lower? So I just got rid of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of maintaining plan definitions in the tests, they should be read from the source of truth - the
.envrcfile. This reduces duplication and the tendency for the definitions to drift apart.