chore: stop setting duplicate environment variables #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Makefile and push-broker.sh script all have duplicates of variables in .envrc. Now is the time to reduce that duplication since the .envrc pattern has been widely adopted.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/184507504 The labels on this github issue will be updated when the story is started. |
|
Would this work in CI as well or we need to change it to allow direnv? |
|
Absolutely, a change is required in CI too: https://github.com/pivotal/cloud-service-broker-ci/commit/e7b2fa9618d71cf00d48fb2b48a7f43cee12b079 |
Thanks, completely missed that commit. |
pivotal-marcela-campo
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile and push-broker.sh script all have duplicates of variables in .envrc. Now is the time to reduce that duplication since the .envrc pattern has been widely adopted.