feat: Add option to enable audit log export to cloudwatch #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelisiaM
changed the title
nouseforaname
force-pushed
the
feat/audit-logging-min
branch
from
4534b71
to
512bfc9
Compare
[#183457241] We want to enable users to be able to export their audit logs for a service instance. This adds the required resources and input variables to enable exporting audit logs to cloudwatch. This setting requires providing a properly configured option_group identified by `option_group_name` (enabling the audit log plugin, (see)[https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Appendix.MySQL.Options.AuditPlugin.html] ) Known Issues: IF an instance is created without audit log enabled AND then the Instance get's updated to enable audit logging AND then the Instance get's updated to disable audit logging THEN the log group created in step 2 will NOT be deleted. This will create an issue if you try to set audit logging to true again because terraform will error trying to create an existing log group. To avoid this, the log groups use name_prefix rather than name.
nouseforaname
force-pushed
the
feat/audit-logging-min
branch
from
512bfc9
to
045b27c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#183457241]
We want to enable users to be able to export their audit logs for a service instance. This adds the required resources and input variables to enable exporting audit logs to cloudwatch. This setting requires providing a properly configured option_group identified by
option_group_name(enabling the audit log plugin, (see)[https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Appendix.MySQL.Options.AuditPlugin.html] )Known Issues:
IF an instance is created without audit log enabled AND then the Instance get's updated to enable audit logging AND then the Instance get's updated to disable audit logging
THEN the log group created in step 2 will NOT be deleted.
This will create an issue if you try to set audit logging to true again because terraform will error trying to create an existing log group.
To avoid this, the log groups use name_prefix rather than name.
Checklist:
* [ ] Have you added Release Notes in the docs repositories?