-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set retention period only when enabling functionality #539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
terraform-tests/mysql_test.go
Outdated
Expect(AfterValuesForType(plan, "aws_db_instance")).To( | ||
MatchKeys(IgnoreExtras, Keys{ | ||
"performance_insights_enabled": Equal(true), | ||
"performance_insights_retention_period": Equal(float64(retentionPeriod)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: I'm not sure we should compare to a float, as it is an internal detail; we may want to use BeNumerically
matcher here to avoid using specific types.
terraform-tests/postgres_test.go
Outdated
Expect(AfterValuesForType(plan, "aws_db_instance")).To( | ||
MatchKeys(IgnoreExtras, Keys{ | ||
"performance_insights_enabled": Equal(true), | ||
"performance_insights_retention_period": Equal(float64(retentionPeriod)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
#183485960
Checklist:
[ ] Have you added Release Notes in the docs repositories?